Autocomplete: reopen @-mention suggestions when backspacing inside formatted mentions#2040
Autocomplete: reopen @-mention suggestions when backspacing inside formatted mentions#2040cybernova2 wants to merge 1 commit intozulip:mainfrom
Conversation
…ted mentions Match web behavior by reopening mention autocomplete when backspacing inside formatted mentions like @**Name**. Update model and widget tests to reflect the new autocomplete lifecycle.
|
This implementation doesn't look how I would expect it to. #1967 points to the implementation of a "similar behavior" in another kind of autocomplete—could you please read that carefully and use it to inform your work here? |
|
Closing because I don't expect this PR to become something that's a good use of our time to review. @cybernova2 Please take the time to read our contributing guide, which is linked to in our README. This issue isn't marked with "help wanted", because we don't expect it to be accessible to a new contributor. As the contributing guide says:
Moreover you have an active PR already — in fact two of them, #2019 and #2025. As the contributing guide says, please stick to one issue at a time until you have a first PR merged in Zulip. There's plenty for you to fix in those PRs before you ask the core team to spend more time again reviewing another PR. |
3 participants
This PR updates the @-mention autocomplete behavior to match the web app.
When a user backspaces inside a formatted mention (e.g.
@**Chris Bobbe**),the autocomplete is now reopened by stripping the formatting and re-evaluating
the mention query, instead of suppressing autocomplete entirely.
As part of this change:
before matching.
inside formatted mentions.
autocomplete UI, which is now unmounted when no valid intent exists
instead of remaining visible with empty results.
pending timers at teardown.
Screenshots attached show the behavior before and after this change.
Before: Backspacing inside a formatted mention does not reopen autocomplete.
After: Autocomplete reopens correctly, matching web behavior.
Fixes #1967